-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add security context for cleanup hook #966
feat: add security context for cleanup hook #966
Conversation
Hi @afrimberger Could you fix the DCO (sign the commit) so that all tests pass? |
c5b5ab2
to
25ea52e
Compare
Hi @TheBigLee, DCO is "green", now. Thanks for the hint. I just looked at the Check list and didn't notice the red DCO build. Would be worth adding an entry "Commits signed off" to the Check list :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing.
Once you've fixed this and the e2e ran through we can merge.
5073025
to
1bf80f1
Compare
@afrimberger Can you run Cheers |
Thanks for the idea. We've added it to the checklist in #974 |
Signed-off-by: André Frimberger <[email protected]>
1bf80f1
to
8b39c30
Compare
Signed-off-by: André Frimberger <[email protected]>
Signed-off-by: André Frimberger <[email protected]>
ab49abd
to
77180bf
Compare
@TheBigLee : docs are updated and I added another small commit for fixing the labels for the Grafana Dashboard ConfigMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution 🎉
Summary
The operator deployment already supports setting
podSecurityContext
andsecurityContext
. This PR allows setting both for the cleanup Job.Checklist
For Helm Chart changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog
area:chart
chart:k8up
make chart-docs