Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made cleanup hook job honor pullSecret settings #957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made cleanup hook job honor pullSecret settings #957

wants to merge 1 commit into from

Conversation

albimn
Copy link

@albimn albimn commented Apr 17, 2024 •
edited by Kidswiss
Loading

Summary

Changed Helm Chart to honor settings for pullSecrets also for the cleanup hook.

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@albimn albimn requested a review from a team as a code owner April 17, 2024 11:02
@albimn albimn requested review from TheBigLee and wejdross and removed request for a team April 17, 2024 11:02
@albimn albimn marked this pull request as draft April 17, 2024 11:03
@albimn albimn marked this pull request as ready for review April 17, 2024 11:03
@Kidswiss Kidswiss self-requested a review April 18, 2024 09:33
@Kidswiss Kidswiss added bug Something isn't working area:chart chart:k8up labels Apr 30, 2024
@Kidswiss
Copy link
Contributor

Hi @albimn

Could you please fix the DCO?

@TheBigLee
Copy link
Contributor

TheBigLee commented May 28, 2024 •
edited
Loading

@albimn Please sign the commit to fix the DCO and also run make chart-docs to fix the ChartLint check.
Furthermore a rebase is required now.
Until this is fixed, we can't merge this PR.

Cheers Nicolas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee is a code owner automatically assigned from k8up-io/maintainer

@wejdross wejdross Awaiting requested review from wejdross wejdross is a code owner automatically assigned from k8up-io/maintainer

@Kidswiss Kidswiss Awaiting requested review from Kidswiss

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:chart bug Something isn't working chart:k8up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albimn @Kidswiss @TheBigLee @malbiez