Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add values to overwrite cleanup image #890

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: Add values to overwrite cleanup image #890

merged 1 commit into from
Sep 27, 2023

Conversation

nheinemans-asml
Copy link
Contributor

@nheinemans-asml nheinemans-asml commented Sep 26, 2023 •
edited
Loading

Summary

Adding new values to allow getting the cleanup image (bitnami/kubectl) from an internal registry.
Solves issue #889

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@nheinemans-asml nheinemans-asml requested a review from a team as a code owner September 26, 2023 09:15
@nheinemans-asml nheinemans-asml requested review from TheBigLee and wejdross and removed request for a team September 26, 2023 09:15
@Kidswiss
Copy link
Contributor

Hi @nheinemans-asml

Thanks for the contribution!

Can you please run make chart-docs and push that as well? That will genearte the docs for the new parameters.

Also the DCO is required for the PR checks to pass.

@nheinemans-asml nheinemans-asml force-pushed the cleanup-image-values branch 2 times, most recently from bf39b76 to 0e988a3 Compare September 26, 2023 12:57
Kidswiss
Kidswiss requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing, then it should be okay.

charts/k8up/values.yaml Outdated Show resolved Hide resolved
@nheinemans-asml nheinemans-asml force-pushed the cleanup-image-values branch 3 times, most recently from 4c87156 to 5da1d77 Compare September 27, 2023 10:48
@nheinemans-asml
Copy link
Contributor Author

Just one more thing, then it should be okay.

Almost there, I forgot to run make chart-docs after my last change.

@Kidswiss
Copy link
Contributor

Just one more thing, then it should be okay.

Almost there, I forgot to run make chart-docs after my last change.

Yeah the readme still says hub.docker.com :)

Kidswiss
Kidswiss approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Thanks for the contribution!

@Kidswiss Kidswiss merged commit ba9fb58 into k8up-io:master Sep 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee is a code owner automatically assigned from k8up-io/maintainer

@wejdross wejdross Awaiting requested review from wejdross wejdross is a code owner automatically assigned from k8up-io/maintainer

Assignees
No one assigned
Labels
area:chart chart:k8up enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nheinemans-asml @Kidswiss