Fail if the backup command in the annotation exits != 0 #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
tobru and
lieneluksika
and removed request for
a team
Kidswiss
commented
Dec 5, 2024
| @@ -262,16 +263,17 @@ func (b *BackupExecutor) startBackup(ctx context.Context) error { | |||
| } | |||
| // each job sleeps for index seconds to avoid concurrent restic repository creation. Not the prettiest way but it works and a repository | |||
| // is created only once usually. | |||
| if index > 0 { | |||
| if name == "prebackup" || index != 0 { | |||
There was a problem hiding this comment.
This fixes another small but unrelated issue.
If there's a PVC backup AND prebackup commands, it can happen that both want to restic init at the same time, which will corrupt the repo.
Kidswiss
force-pushed
the
fix/false-positive-backups
branch
3 times, most recently
from
bd79e89 to
b48d5f3
Compare
Kidswiss
requested review from
TheBigLee,
wejdross and
zugao
and removed request for
tobru and
lieneluksika
This will fix issues were problems with pre-backup go undected. K8up will now completely fail the whole whole prebackup pod if the commands exist with a code != 0. Also a small issue with concurrent `restic init` was fixed. Signed-off-by: Simon Beck <[email protected]>
Kidswiss
force-pushed
the
fix/false-positive-backups
branch
from
b48d5f3 to
194e331
Compare
wejdross
reviewed
Dec 9, 2024
wejdross
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will fix issues were problems with pre-backup go undected. K8up will now completely fail the whole whole prebackup pod if the commands exist with a code != 0.
Also a small issue with concurrent
restic initwas fixed.Fixes: #910
Checklist
For Code changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:operatorcharts/directory.