fix(restic): Don't set --options if there are none
#1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutter
requested review from
tobru and
wejdross
and removed request for
a team
wejdross
approved these changes
Oct 9, 2024
Calling `strings.Split` on an empty string still returns a slice with one empty string in it, hence setting `options`. This commit changes the implementation to _first_ check for empty strings, before even calling `strings.Split`. Signed-off-by: Manuel Hutter <[email protected]>
mhutter
force-pushed
the
fix/empty-options
branch
from
5f41381 to
8cb211a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
strings.Spliton an empty string still returns a slice with one empty string in it, hence settingoptions.This commit changes the implementation to first check for empty strings, before even calling
strings.Split.Checklist
For Code changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:operatorcharts/directory.