Integration branch: OpenAPI Client generation #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Miles-Garnsey
changed the title
emerkle826
force-pushed
the
feature/client-gen
branch
3 times, most recently
from
0f46b5a
to
6b965aa
Compare
|
One note on this PR for posterity: we were unable to provide adequate testing around the v2 repairs endpoint because (as discussed here) we could not test the generated client due to limitations with Maven. Reviewers should note that (while we could technically test this using an HTTP-only testing approach) it seems late in the game to do so, and my understanding is that this is urgently needed to meet our next milestone. |
adejanovski
approved these changes
Oct 12, 2023
emerkle826
commented
Oct 12, 2023
| @@ -51,6 +82,14 @@ public void setStatus(JobStatus status) { | |||
| this.status = status; | |||
| } | |||
|
|
|||
| public void setStatusChange(ProgressEventType type, String message) { | |||
There was a problem hiding this comment.
suggestion:
This is probably better named addStatusChange
…hema (#346) * Add currentStreams DTO * add cluster name into endpoints response
* Add repair job version which follows notifications * Add new getStatusChanges and message * Fix formatting * Add tests for the async endpoint in v1 also * Change setStatusChange * Fix test indentation * Rename RpcParam * Fix rebase * Add back the payload in the IT test to the request * Update openapi.json, make special case for return id 0 to the Rpc call - should fix the test also which can not be run otherwise on single node cluster * Disable the test, throw exception if Cassandra refuses to repair * Fix repair test to run repair for a keyspace with RF 2 (#351) * Update openapi.json after rebase --------- Co-authored-by: Erik Merkle <[email protected]>
* Allow `repair()` RPC method to take more arguments (as required by Reaper). Get the old NodeOpsResources class calling the new RPC method signature. --------- Co-authored-by: Erik Merkle <[email protected]> * Cancel repairs endpoint (#368) * Add cancelAllRepairs endpoint and requisite NodeOps.
…h BigIntegers being represented in open API spec as ints. (#370)
* Correctly serialize and deserialize the statusChanges field * Use escaped JSON instead when returning from getJobStatus
* Fix bug in getRingRangeString(), add unit test, add integration test.
* Make sure getJobStatus named consistently. * Ensure status changes are serialised as JSON arrays, not as string.
emerkle826
force-pushed
the
feature/client-gen
branch
from
ba69e9f
to
25957a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the aggregate PR to merge all of the smaller OpenAPI client generation updates into the main branch once it's all finished.