Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify YAML parsing to parse multiple documents per file #35

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Modify YAML parsing to parse multiple documents per file #35

merged 5 commits into from
Apr 22, 2024

Conversation

burmanm
Copy link
Collaborator

@burmanm burmanm commented Apr 19, 2024 •
edited
Loading

Indicate what we're doing in the CRD processing

Fixes #36

olim7t
olim7t approved these changes Apr 19, 2024
View reviewed changes
Copy link

@olim7t olim7t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a minor issue that I think we need to address (see inline comment).

[nitpick] The PR title does not accurately describe the change (which IIUC is mainly about YAML files containing multiple CRDs).

pkg/helmutil/crds.go Show resolved Hide resolved
@burmanm burmanm changed the title Add unit test to verify findCRDs and logging Modify YAML parsing to parse multiple documents per file Apr 22, 2024
@burmanm burmanm merged commit 0e1bf9a into k8ssandra:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olim7t olim7t olim7t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CRD upgrader's YAML processing
2 participants
@burmanm @olim7t