Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP connection support for OVS #330

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tabuhariri
Copy link
Contributor

@tabuhariri tabuhariri commented Nov 7, 2024

  • Extend OVS connection options beyond Unix sockets
  • Implement TCP endpoint configuration for marker binary
  • Use -ovs-socket flag with format "tcp::"

Example usage: -ovs-socket tcp:127.0.0.1:6640

What this PR does / why we need it:

Add Support for ovs tcp connection

Special notes for your reviewer:

Release note:

This feature allows for remote OVS connections, enhancing flexibility in network configurations.
User will be allowed to use tcp connection to OVS by specifying OVS socket endpoint by using -ovs-socket flag with tcp endpoint "tcp:<IP>:<PORT>".

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @tabuhariri. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@phoracek
Copy link
Member

phoracek commented Nov 7, 2024

Hello @tabuhariri, thanks for the contribution and making the code a little cleaner with it.

I will need you so sign the commit - you can do that by running git commit -s --amend and pushing the updated commit to this branch.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 7, 2024
@tabuhariri tabuhariri force-pushed the ovs_tcp_conn_pr branch 3 times, most recently from 14c7c33 to 3829979 Compare November 7, 2024 11:03
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 7, 2024
@tabuhariri
Copy link
Contributor Author

Hello @tabuhariri, thanks for the contribution and making the code a little cleaner with it.

I will need you so sign the commit - you can do that by running git commit -s --amend and pushing the updated commit to this branch.

Hello Petr,
Sure no problem, I've signed the commit and added the release label.
While implementing remote OVS connection support, I took the opportunity to refactor the existing code slightly without significantly altering the core logic.

@phoracek
Copy link
Member

phoracek commented Nov 7, 2024

/retest

@phoracek
Copy link
Member

phoracek commented Nov 7, 2024

@tabuhariri sorry, it seems that the e2e test suite is broken (unrelated to your PR). I'll try to look into it ASAP

cmd/marker/main.go Outdated Show resolved Hide resolved
@phoracek
Copy link
Member

/retest

@tabuhariri
Copy link
Contributor Author

/retest

@kubevirt-bot
Copy link
Collaborator

@tabuhariri: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tabuhariri
Copy link
Contributor Author

/retest-required

@kubevirt-bot
Copy link
Collaborator

@tabuhariri: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tabuhariri
Copy link
Contributor Author

@tabuhariri sorry, it seems that the e2e test suite is broken (unrelated to your PR). I'll try to look into it ASAP

I have a potential fix for the e2e test suite:
#334

@phoracek
Copy link
Member

/retest

@tabuhariri thanks again for the fix. Let's see if the PR gets automatically based on it, or if you'll have to rebase.

@tabuhariri
Copy link
Contributor Author

/retest

@tabuhariri thanks again for the fix. Let's see if the PR gets automatically based on it, or if you'll have to rebase.

I really appreciate your prompt responses. Thank you for being so attentive!
Just to make it easier on the merge process, I have rebased my commit.

cmd/marker/main.go Outdated Show resolved Hide resolved
cmd/marker/main.go Outdated Show resolved Hide resolved
- Extend OVS connection options beyond Unix sockets
- Implement TCP endpoint configuration for marker binary
- Use -ovs-socket flag with format "tcp:<IP>:<PORT>"

Example usage: -ovs-socket tcp:127.0.0.1:6640

**What this PR does / why we need it**:

Add Support for ovs tcp connection

**Special notes for your reviewer**:

**Release note**:

```release-note
This feature allows for remote OVS connections, enhancing flexibility in network configurations.
User will be allowed to use tcp connection to OVS by specifying OVS
socket endpoint by using -ovs-socket flag with tcp endpoint "tcp:<IP>:<PORT>".
```

Signed-off-by: Tarek Abu-Hariri <[email protected]>
@phoracek
Copy link
Member

/retest

Thanks! I appreciate you leaving the code in a better state than you've found it.

@phoracek
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, tabuhariri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@kubevirt-bot kubevirt-bot merged commit 546b351 into k8snetworkplumbingwg:main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants