-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TCP connection support for OVS #330
Add TCP connection support for OVS #330
Conversation
Hi @tabuhariri. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hello @tabuhariri, thanks for the contribution and making the code a little cleaner with it. I will need you so sign the commit - you can do that by running |
a521c3d
to
ee6121e
Compare
14c7c33
to
3829979
Compare
3829979
to
f396588
Compare
Hello Petr, |
/retest |
@tabuhariri sorry, it seems that the e2e test suite is broken (unrelated to your PR). I'll try to look into it ASAP |
f396588
to
2044a6a
Compare
/retest |
2044a6a
to
9158a6f
Compare
/retest |
@tabuhariri: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
@tabuhariri: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I have a potential fix for the e2e test suite: |
/retest @tabuhariri thanks again for the fix. Let's see if the PR gets automatically based on it, or if you'll have to rebase. |
9158a6f
to
646aad1
Compare
I really appreciate your prompt responses. Thank you for being so attentive! |
- Extend OVS connection options beyond Unix sockets - Implement TCP endpoint configuration for marker binary - Use -ovs-socket flag with format "tcp:<IP>:<PORT>" Example usage: -ovs-socket tcp:127.0.0.1:6640 **What this PR does / why we need it**: Add Support for ovs tcp connection **Special notes for your reviewer**: **Release note**: ```release-note This feature allows for remote OVS connections, enhancing flexibility in network configurations. User will be allowed to use tcp connection to OVS by specifying OVS socket endpoint by using -ovs-socket flag with tcp endpoint "tcp:<IP>:<PORT>". ``` Signed-off-by: Tarek Abu-Hariri <[email protected]>
646aad1
to
12c9e0b
Compare
/retest Thanks! I appreciate you leaving the code in a better state than you've found it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek, tabuhariri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Example usage: -ovs-socket tcp:127.0.0.1:6640
What this PR does / why we need it:
Add Support for ovs tcp connection
Special notes for your reviewer:
Release note: