go.mod: Update go version to 1.21 #427
Conversation
| @@ -1,6 +1,6 @@ | |||
| module github.com/k8snetworkplumbingwg/kubemacpool | |||
|
|
|||
| go 1.19 | |||
| go 1.21.9 | |||
There was a problem hiding this comment.
Thanks, did you run make vendor ?
asking because iirc a toolchain would be added once you do
but on the other hand i guess you did
There was a problem hiding this comment.
FYI I ran it now, but the toolchain thing was not added. Maybe it's only on 1.22+?
There was a problem hiding this comment.
maybe ye, anyhow once you ran we are good
(worth to add make vendor on CI unit tests on a followup)
There was a problem hiding this comment.
btw seems it is from 1.21
https://go.dev/doc/toolchain
not sure why it is not added, but we will figure in the future, doesn't matter as long as everything works
The current version 1.19 is causing `make generate` to fail on format issue. Updating to 1.21. Also updating the deepcopy-gen flags as the older ones are no longer supported. Also run make vendor. Signed-off-by: Ram Lavi <[email protected]>
|
/cherry-pick release-0.43 |
|
@RamLavi: once the present PR merges, I will cherry-pick it on top of release-0.43 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@RamLavi: new pull request created: #429 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The current version 1.19 is causing
make generateto fail on format issue.Updating to 1.21.
Also updating the
deepcopy-genflags as the older ones are no longer supported.Special notes for your reviewer:
Release note: