-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kube-rbac-proxy #404
Bump kube-rbac-proxy #404
Conversation
/cc @RamLavi |
@@ -138,7 +138,7 @@ spec: | |||
capabilities: | |||
drop: | |||
- ALL | |||
image: quay.io/openshift/origin-kube-rbac-proxy:4.10.0 | |||
image: quay.io/openshift/origin-kube-rbac-proxy:4.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want hash or version
hash is static but might be deleted (we are using hash on CNAO fwiw)
version is dynamic, not deleted by might present flakes.
Can you please update the commit desc? Or is it a WIP PR that is only meant to confirm CNAO? |
Includes openshift/kube-rbac-proxy#80 Signed-off-by: Or Shoval <[email protected]>
fe25e40
to
d71cbc9
Compare
Done, not a WIP anymore, just forgot to update |
Interesting here I dont think it is related to the PR btw few days ago there was also this one (on other PR) in this area more or less If you want i can open issue for those 2 |
/retest not related to this PR imo |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Includes openshift/kube-rbac-proxy#80
Special notes for your reviewer:
Release note: