Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump runc to v1.2 #10896

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Bump runc to v1.2 #10896

merged 1 commit into from
Nov 5, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Sep 14, 2024

Proposed Changes

bump runc to v1.2

Types of Changes

version bump

Verification

check runc version

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner September 14, 2024 07:31
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.47%. Comparing base (8ea6154) to head (23dcdd4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10896      +/-   ##
==========================================
+ Coverage   34.29%   42.47%   +8.18%     
==========================================
  Files         162      179      +17     
  Lines       17979    18569     +590     
==========================================
+ Hits         6166     7888    +1722     
+ Misses      10770     9474    -1296     
- Partials     1043     1207     +164     
Flag Coverage Δ
e2etests 34.25% <ø> (-0.04%) ⬇️
inttests 34.75% <ø> (?)
unittests 13.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vitorsavian
vitorsavian previously approved these changes Sep 15, 2024
manuelbuil
manuelbuil previously approved these changes Sep 16, 2024
@brandond brandond marked this pull request as draft September 16, 2024 17:34
@brandond brandond dismissed stale reviews from manuelbuil and vitorsavian via 9fca04c November 4, 2024 20:55
@brandond brandond marked this pull request as ready for review November 4, 2024 20:55
@brandond brandond requested review from manuelbuil, vitorsavian and a team November 4, 2024 20:56
dereknola
dereknola previously approved these changes Nov 4, 2024
Signed-off-by: Brad Davidson <[email protected]>
@brandond
Copy link
Member Author

brandond commented Nov 5, 2024

Also pins cilium/ebpf below v0.13.0 to avoid the issue described at opencontainers/runc#4397 (comment)

This caused k3s to segfault on arm:

unexpected fault address 0xe5801014
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x1 addr=0xe5801014 pc=0x7fdb54]
...
runtime: g 4590: unexpected return pc for k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer.(*objectOps[*k8s.io/api/flowcontrol/v1.FlowSchema]).Get called from 0x5d4541d
stack: frame={sp:0x1194bcb4, fp:0x1194bcd0} stack=[0x1194a000,0x1194c000)
0x1194bc34:  0x0000000c  0x05af1f00  0x00000000  0x00000000
0x1194bc44:  0x03a57698 <k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer.EnsureConfigurations[go.shape.*k8s.io/api/flowcontrol/v1.FlowSchema]+0x0000007c>  0x1059d640  0x05d4541d  0x0000000c
0x1194bc54:  0x13210010  0x0bb6b388  0x00000000  0x00000000
0x1194bc64:  0x00000000  0x00000000  0x0002c0b0 <runtime.(*mspan).writeHeapBitsSmall+0x00000068>  0x00021e9c <runtime.mallocgc+0x000007d4>
0x1194bc74:  0xf6aae3c0  0x0e92a600  0x13addf00  0x00000040
0x1194bc84:  0x00000040  0x0002c34c <runtime.heapSetType+0x0000016c>  0xf7696280  0x00090be8 <runtime.rtype.textOff+0x00000160>
0x1194bc94:  0x0000000c  0x00000040  0x0002c0b0 <runtime.(*mspan).writeHeapBitsSmall+0x00000068>  0x0002c0b0 <runtime.(*mspan).writeHeapBitsSmall+0x00000068>
0x1194bca4:  0x0001ef8c <runtime.(*itab).init+0x000002f8>  0x0001eec0 <runtime.(*itab).init+0x0000022c>  0x00000009  0x0e85a848
0x1194bcb4: <0x05d4541d  0x00000040  0x0002c34c <runtime.heapSetType+0x0000016c>  0xf607e728
0x1194bcc4:  0x13211f00  0x00000040  0x05d36b49 >0x00000002
0x1194bcd4:  0x00000010  0x00000008  0x00021e9c <runtime.mallocgc+0x000007d4>  0xf607e728
0x1194bce4:  0x13210070  0x0000000c  0x056fa9d0  0x00000008
0x1194bcf4:  0x000217f4 <runtime.mallocgc+0x0000012c>  0x000217f4 <runtime.mallocgc+0x0000012c>  0x0001eba8 <runtime.itabAdd+0x000000e8>  0x0b90bbd4
0x1194bd04:  0x0001f3fc <runtime.convT+0x0000002c>  0x00022388 <runtime.newobject+0x0000002c>  0x13210070  0x0000000c
0x1194bd14:  0x056fa9d0  0x00000000  0xf607e728  0x00000008
0x1194bd24:  0x00000400  0xf6220000  0xf607e728  0x00000010
0x1194bd34:  0x03a54b08 <k8s.io/kubernetes/pkg/registry/flowcontrol/rest.ensureSuggestedConfiguration+0x000002cc>  0x06cc2168  0x06cba6c4  0x0b94e7e0
0x1194bd44:  0x06ccdd78  0x1059d640  0x0bb6b808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants