Specify port in 'Test_isValidResolvConf' #10532
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR expands testing of the 'Valid ResolvConf' scenario (
pkg/agent/config/config_internal_test.go
).Types of Changes
New Feature
*I was not able to run tests locally, so I'm opening a pull request for the explicit purpose of running tests in CI. I'd like to know whether or not port numbers are supported, when installing with the
--resolv-conf
flag.In other words, where an end-user might run a DNS server on an alternate port, and provide that number in a configuration file (e.g.
/etc/rancher/k3s/resolv.conf
) when installing like the following:curl -sfL https://get.k3s.io | sh -s - --write-kubeconfig-mode 644 --resolv-conf /etc/rancher/k3s/resolv.conf
Verification
If CI passes, I expect that to be enough verification.
Testing
Yes.
Linked Issues
N/A
User-Facing Change
Further Comments