Add and fix golangci issues #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekarlso
force-pushed
the
golang-ci
branch
2 times, most recently
from
ea232aa
to
9fce4ec
Compare
zawachte
reviewed
Jul 21, 2023
| @@ -168,15 +168,15 @@ deploy-controlplane: manifests-controlplane | |||
|
|
|||
| # Generate manifests e.g. CRD, RBAC etc. | |||
| manifests-controlplane: $(KUSTOMIZE) $(CONTROLLER_GEN) | |||
| $(CONTROLLER_GEN) rbac:roleName=manager-role webhook crd paths="./..." output:crd:artifacts:config=controlplane/config/crd/bases output:rbac:dir=bootstrap/config/rbac | |||
| $(CONTROLLER_GEN) rbac:roleName=manager-role webhook crd paths="./..." output:crd:artifacts:config=controlplane/config/crd/bases output:rbac:dir=controlplane/config/rbac | |||
There was a problem hiding this comment.
just noticed this typo. This may have the potential to break functionality. We need to double check the rbac of the controlplane provider.
|
@ekarlso ready for review? |
|
I am currently not able to access my test env to try it out :( |
|
@ekarlso ready for review? |
zawachte
reviewed
Aug 8, 2023
| @@ -517,34 +513,32 @@ func (r *KThreesConfigReconciler) generateAndStoreToken(ctx context.Context, sco | |||
| // it is possible that secret creation happens but the config.Status patches are not applied | |||
| if err := r.Client.Create(ctx, secret); err != nil { | |||
| if !apierrors.IsAlreadyExists(err) { | |||
| return "", errors.Wrapf(err, "failed to create token for KThreesConfig %s/%s", scope.Config.Namespace, scope.Config.Name) | |||
| return "", fmt.Errorf("failed to create token for KThreesConfig %s/%s: %w", scope.Config.Namespace, scope.Config.Name, err) | |||
There was a problem hiding this comment.
which linter favors fmt.Errorf?
zawachte
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.