Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support SSA patch for metadata propagation #136

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nasusoba
Copy link
Contributor

@nasusoba nasusoba commented Aug 14, 2024

This PR supports ssa patch for capi k3s. With it, the mutable fields on KThreesControlPlane will be propagated to the underlying machines/infrastructureMachine/kthreesconfigs without rollout. Fixed #134

SSA (Server-Side Apply) is needed so that if a label is deleted in KThreesControlPlane, it will also get cleaned up from the underlying resources.

@nasusoba nasusoba changed the title [WIP] feat: Support SSA patch for metadata propagation feat: Support SSA patch for metadata propagation Aug 20, 2024
@nasusoba nasusoba marked this pull request as ready for review August 20, 2024 03:02
Signed-off-by: nasusoba <[email protected]>

finished implementation

Signed-off-by: nasusoba <[email protected]>

add test

Signed-off-by: nasusoba <[email protected]>

fix ssaCache init

Signed-off-by: nasusoba <[email protected]>

increase control plane replicas for test

Signed-off-by: nasusoba <[email protected]>

fix typo

Signed-off-by: nasusoba <[email protected]>

fix typo
@mogliang mogliang merged commit cdadf3c into k3s-io:main Aug 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants