fix: Set requeue time for etcd proxy [etcd proxy][v0.2.0] #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasusoba
changed the title
mogliang
reviewed
Jun 13, 2024
| @@ -130,7 +130,7 @@ func (r *MachineReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct | |||
| } | |||
| if !etcdRemoved { | |||
| logger.Info("wait k3s embedded etcd controller to remove etcd") | |||
| return ctrl.Result{Requeue: true}, err | |||
| return ctrl.Result{RequeueAfter: etcdRemovalRequeueAfter}, err | |||
There was a problem hiding this comment.
can we change err to nil?
return ctrl.Result{RequeueAfter: etcdRemovalRequeueAfter}, nil
There was a problem hiding this comment.
the value of err is already nil, but we could also set it explicitly, to be super clear that there is no err
Signed-off-by: nasusoba <[email protected]>
mogliang
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not set a requeue time for etcd proxy machine controller, so the request will be requeued immediately. This triggered lots of requeue, which results the requeue time hits the rate limter upper limit (~
16.67mwhich is too long for deletion). As the time between CAPI initialize the etcd removal request to the etcd member is actually removed, it might take ~ 1min. Add a requeue time of 30s so the controller will wait for a while until it pinging the api server again.