Check k3s-serving secret to determine controlPlane.Status.Initialized #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
force-pushed
the
implement_control_plane_initialized
branch
from
071f5ce
to
76fdec5
Compare
|
Would you mind add some background for this k3s-serving? I'm not very familar with this. |
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
implement_control_plane_initialized
branch
from
76fdec5
to
d7c4ba2
Compare
|
@mogliang I added a little comment to elaborate on this secret we fetch and why. |
mogliang
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a deadlock scenario with the
controlPlane.Status.Initializedwhen theCloudControllermodule is disabled andcloud-provider=externalis set as kubelet arg.In this case k3s will not set
Nodes.Spec.ProviderID, which is the expected behavior.The CAPI Infrastructure provider should set the ProviderID, but in order to set it, the
controlPlane.Status.Initializedneeds to be true first.For reference, this is a mirror implementation from the RKE2 provider: rancher/cluster-api-provider-rke2#302