Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix k3s v1beta1 openstack #101

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Fix k3s v1beta1 openstack #101

merged 2 commits into from
Apr 28, 2024

Conversation

pli01
Copy link
Contributor

@pli01 pli01 commented Apr 25, 2024

Hello,

I have tested the sample script on openstack, recently.

Please find a patch for:

  • a small typo in setup.sh script
  • use v1beta1 syntax

Thanks

@pli01
fix bash typo
0440f55 
Signed-off-by: pli01 <[email protected]>
@pli01 pli01 force-pushed the fix-k3s-v1beta1-openstack branch from b41f6d1 to 363fe4a Compare April 25, 2024 20:32
@mogliang
Copy link
Collaborator

Thanks @pli01 for the fix, did you test openstack sample?

@pli01
Copy link
Contributor Author

pli01 commented Apr 26, 2024

Thanks @pli01 for the fix, did you test openstack sample?

Hi @mogliang , yes i test openstack sample only.

@pli01 pli01 force-pushed the fix-k3s-v1beta1-openstack branch from 363fe4a to 6858a9e Compare April 26, 2024 10:19
@mogliang mogliang merged commit 286bede into k3s-io:main Apr 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogliang mogliang mogliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pli01 @mogliang