-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use piper_phonemize as text tokenizer in vctk TTS recipe #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fall into dev/tts/vctk/tokenizer
csukuangfj
reviewed
Mar 4, 2024
i think `sampling_rate` is an attribute of the model according to the LJSpeech recipe in the master branch (the VCTK recipe soft links the vits.py to the one in LJSpeech), is this the attribute you are referring to?
… On Monday, Mar 04, 2024 at 15:03, Fangjun Kuang ***@***.*** ***@***.***)> wrote:
@csukuangfj commented on this pull request.
In egs/vctk/TTS/vits/export-onnx.py (#1522 (comment)):
> "version": "1", "model_author": "k2-fsa", - "comment": "VITS generator", + "comment": "icefall", # must be icefall for models from icefall + "language": "English", + "voice": "en-us", # Choose your language appropriately + "has_espeak": 1, + "n_speakers": 108, + "sample_rate": 22050, # Must match the real sample rate
Can we obtain the sample rate from the model?
Is sample_rate an attribute of the model?
—
Reply to this email directly, view it on GitHub (#1522 (review)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AOON42DEY54SUQX6GGZXSADYWQME3AVCNFSM6AAAAABD7SIFQGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJTGUYDCOBRGU).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Pretrained model can be found here: https://huggingface.co/zrjin/icefall-tts-vctk-vits-2024-03-18 |
yaozengwei
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
akin to #1511 by @yaozengwei