Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let cleanup steps hold their own data #5194

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Let cleanup steps hold their own data #5194

wants to merge 8 commits into from
+93 −124

Commits on Nov 29, 2024

  1. Remove unused CfgFile variable 

    Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d3a657f View commit details
    Browse the repository at this point in the history

  2. Replace hard-coded run dir in cleanup 

    Use the run dir from the config struct instead.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    389ec3f View commit details
    Browse the repository at this point in the history

  3. Remove unused config pointer from services cleanup step 

    Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    6cb0fca View commit details
    Browse the repository at this point in the history

  4. Use explicit dependencies in the directories cleanup step 

    So it's obvious which parts of the config it uses.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    84a3945 View commit details
    Browse the repository at this point in the history

  5. Use explicit dependencies in the users cleanup step 

    So it's obvious which parts of the config it uses.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    dd08846 View commit details
    Browse the repository at this point in the history

  6. Use containerd component in the containers cleanup step 

    Instead of its own bespoke way of setting up containerd.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    0fd255d View commit details
    Browse the repository at this point in the history

  7. Move the cleanup steps creation into NewConfig 

    Now that the steps hold their onw data, the cleanup step creation can be
moved into the NewConfig function, and the Config struct only needs to
care about the step slice.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    bed7162 View commit details
    Browse the repository at this point in the history

  8. Move the containers cleanup step creation into its own func 

    Makes the code a bit clearer.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3cfc6fd View commit details
    Browse the repository at this point in the history