Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs link to fish shell #4505

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented May 28, 2024

Description

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Fixes: 316d623 ("Overhaul shell completion docs")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added documentation Improvements or additions to documentation chore backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels May 28, 2024
@twz123 twz123 marked this pull request as ready for review May 28, 2024 08:42
@twz123 twz123 requested a review from a team as a code owner May 28, 2024 08:42
@twz123 twz123 requested review from makhov and jnummelin May 28, 2024 08:42
@twz123 twz123 merged commit 070a115 into k0sproject:main May 28, 2024
10 checks passed
@twz123 twz123 deleted the fix-doclink-fish branch May 28, 2024 11:43
@k0s-bot
Copy link

k0s-bot commented May 28, 2024

Successfully created backport PR for release-1.30:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch chore documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants