-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-1.28] feat: implement watcher for oci bundles #4428
Merged
twz123
merged 10 commits into
k0sproject:release-1.28
from
ricardomaraschini:release-1.28-carry-over
May 24, 2024
Merged
[Backport release-1.28] feat: implement watcher for oci bundles #4428
twz123
merged 10 commits into
k0sproject:release-1.28
from
ricardomaraschini:release-1.28-carry-over
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements an oci bundle watcher. this allows k0s to load new bundles without requiring a restart of the process. the watcher acts upon create or write operations happening in the oci bundles directory. events are debounced with a timeout of 10 seconds. Signed-off-by: Ricardo Maraschini <[email protected]>
create a function to import a single oci bundle. use it in our watcher. Signed-off-by: Ricardo Maraschini <[email protected]>
Co-authored-by: Tom Wieczorek <[email protected]> Signed-off-by: Ricardo Maraschini <[email protected]>
Co-authored-by: Tom Wieczorek <[email protected]> Signed-off-by: Ricardo Maraschini <[email protected]>
Co-authored-by: Tom Wieczorek <[email protected]> Signed-off-by: Ricardo Maraschini <[email protected]>
Co-authored-by: Tom Wieczorek <[email protected]> Signed-off-by: Ricardo Maraschini <[email protected]>
Signed-off-by: Ricardo Maraschini <[email protected]>
Signed-off-by: Ricardo Maraschini <[email protected]>
Signed-off-by: Ricardo Maraschini <[email protected]>
a function used to create a buffered channel does not exist on v1.6.0. Signed-off-by: Ricardo Maraschini <[email protected]>
ricardomaraschini
force-pushed
the
release-1.28-carry-over
branch
from
May 16, 2024 09:05
1c4a915
to
b7a9199
Compare
twz123
added
enhancement
New feature or request
area/worker
component/containerd
labels
May 24, 2024
twz123
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
twz123
added
the
backport/release-1.27
PR that needs to be backported/cherrypicked to release-1.27 branch
label
May 24, 2024
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.27
git worktree add -d .worktree/backport-4428-to-release-1.27 origin/release-1.27
cd .worktree/backport-4428-to-release-1.27
git checkout -b backport-4428-to-release-1.27
ancref=$(git merge-base bace82049e94b28d4ca266dc271452106957e52d b7a919960a4f0edccfe61d27f6b9a5250fb3f780)
git cherry-pick -x $ancref..b7a919960a4f0edccfe61d27f6b9a5250fb3f780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/worker
backport/release-1.27
PR that needs to be backported/cherrypicked to release-1.27 branch
component/containerd
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements an OCI bundle watcher. This allows k0s to load new OCI bundles without requiring a restart of the process. The watcher acts upon
Create()
orWrite()
operations happening in the OCI bundles directory and events are debounced with a timeout of 10 seconds.Fixes # 4316
Type of change
How Has This Been Tested?
At this stage I have updated
k0s
locally and created/deleted/updated bundles manually in the OCI bundles directory. I have been checking the results by inspecting the logs (as follow) and withk0s ctr i ls
:Checklist: