Honor API port number in kubeconfig admin subcommand #4340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The subcommand was not properly replacing the internal cluster URL with the external one with a non-default port for the API. Instead of doing a string replacement on the raw kubeconfig, parse it and do a structured replacement of the URL. Adjust the error message when the admin config is missing. Add some comments that give some hints on how the kubeconfig admin subcommand relates to the kubeconfig generation in certificates.go. Add some unit tests.
Type of change
How Has This Been Tested?
Checklist: