Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove kubelet-config component #4108

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 22, 2024

Description

K0s 1.29 did a full removal of the component from the cluster. Remove the old kubelet-config component completely now. Leave some checks in the integration tests that verify the non-existence of the manifest folder of the kubelet-config stack for current versions of k0s.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added this to the 1.30 milestone Feb 22, 2024
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Mar 23, 2024
@twz123 twz123 removed the Stale label Mar 24, 2024
@twz123
Copy link
Member Author

twz123 commented Apr 2, 2024

Tests should pass as soon as the main branch is bumped to Kubernetes 1.30.

@twz123
Copy link
Member Author

twz123 commented Apr 28, 2024

Kubernetes is now bumped to v1.30. This needs to be rebased now.

K0s 1.29 did a full removal of the component from the cluster. Remove
the old kubelet-config component completely now. Leave some checks in
the integration tests that verify the non-existence of the manifest
folder of the kubelet-config stack for current versions of k0s.

See: 412b3c6 ("Remove kubelet-config stack after deprecation in 1.26")
See: 9d0a317 ("Replace kubelet-config with worker-config component")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the remove-kubelet-config-component branch from 35c0924 to 5328a56 Compare April 29, 2024 07:08
@twz123 twz123 marked this pull request as ready for review April 29, 2024 08:44
@twz123 twz123 requested a review from a team as a code owner April 29, 2024 08:44
@twz123 twz123 requested review from kke and makhov April 29, 2024 08:44
@twz123 twz123 merged commit c8da7d9 into k0sproject:main Apr 29, 2024
74 checks passed
@twz123 twz123 deleted the remove-kubelet-config-component branch April 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants