Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused bootstrap-api-auth token usage #4030

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Remove unused bootstrap-api-auth token usage #4030

merged 1 commit into from
Feb 19, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 6, 2024

Description

It has been added as part of the initial Windows support, but it seems it has never been in use. Supposedly this is a remnant of an intermediary variant, and has been renamed to bootstrap-api-worker-calls.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Remove unused bootstrap-api-auth token usage
29fba0c 
It has been added as part of the initial Windows support,
but it seems it has never been in use. Supposedly this is a
remnant of an intermediary variant, and has been renamed to
bootstrap-api-worker-calls.

See: d2251a3 ("Implement different roles in the token/manager to distinguish api for controller nodes and api for worker nodes")
See: 55b5227 ("Apply lost in rebase commit for join token generation")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the chore label Feb 6, 2024
@twz123 twz123 marked this pull request as ready for review February 6, 2024 13:09
@twz123 twz123 requested a review from a team as a code owner February 6, 2024 13:09
@twz123 twz123 requested review from ncopa and makhov February 6, 2024 13:09
@twz123 twz123 merged commit b26d874 into k0sproject:main Feb 19, 2024
74 checks passed
@twz123 twz123 deleted the remove-bootstrap-api-auth-usage branch February 19, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin