Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KUBERNETES_VERSION consistently #3955

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 18, 2024

Description

There were different environment variables in use to transport the current Kubernetes version. Unify that by replacing all KUBE_VERSION usages with KUBERNETES_VERSION.

Don't embed the Kuberntes version in the docs helper Docker container. It's not used during build time. It's required during runtime, though. Hence pass this as an -e parameter to the docker run command instead. Let the Docker container build also depend on the embedded-bins Makefile variables, as the Alpine version is defined over there.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

There were different environment variables in use to transport the
current Kubernetes version. Unify that by replacing all KUBE_VERSION
usages with KUBERNETES_VERSION.

Don't embed the Kuberntes version in the docs helper Docker container.
It's not used during build time. It's required during runtime, though.
Hence pass this as an -e parameter to the docker run command instead.
Let the Docker container build also depend on the embedded-bins Makefile
variables, as the Alpine version is defined over there.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the chore label Jan 18, 2024
@twz123 twz123 marked this pull request as ready for review January 26, 2024 13:09
@twz123 twz123 requested a review from a team as a code owner January 26, 2024 13:09
@twz123 twz123 requested review from ncopa and makhov January 26, 2024 13:09
@twz123 twz123 merged commit 3de6542 into k0sproject:main Feb 19, 2024
75 checks passed
@twz123 twz123 deleted the kube-version branch February 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants