Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate helm clientset #3940

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

juanluisvaladas
Copy link
Contributor

Description

Generate a helm clientset.
We need a clientset for #3651 and it was agreed that it made sense to have it as an external PR to make the other one smaller.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
@juanluisvaladas juanluisvaladas requested a review from a team as a code owner January 17, 2024 10:03
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have done this earlier.

@juanluisvaladas juanluisvaladas merged commit 20fa6bd into k0sproject:main Jan 17, 2024
20 checks passed
@twz123 twz123 changed the title Generate helm clienset Generate helm clientset Jan 17, 2024
@twz123 twz123 added the backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch label Jun 14, 2024
@k0s-bot
Copy link

k0s-bot commented Jun 14, 2024

Successfully created backport PR for release-1.28:

@twz123 twz123 removed the backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants