Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image validation check #3913

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 10, 2024

Description

K0s ships airgap image bundles for all the supported architectures. Whenever an image is not available for a given platform, the bundle generation will fail and give an appropriate CI signal. No need for a separate check.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

K0s ships airgap image bundles for all the supported architectures.
Whenever an image is not available for a given platform, the bundle
generation will fail and give an appropriate CI signal. No need for a
separate check.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the remove-image-validation-check branch from 44b1d90 to cd477dd Compare January 10, 2024 11:45
@twz123 twz123 marked this pull request as ready for review January 11, 2024 11:43
@twz123 twz123 requested a review from a team as a code owner January 11, 2024 11:43
@twz123 twz123 merged commit ce81a33 into k0sproject:main Jan 11, 2024
72 checks passed
@twz123 twz123 deleted the remove-image-validation-check branch January 11, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants