Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reflect.DeepEqual for CoreDNS config comparison #3883

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 5, 2024

Description

Since k0s uses a PDB for CoreDNS, the simple double equals equality check wasn't appropriate to check if the CoreDNS configuration has changed. The struct now contains a pointer which is always different for newly constructed structs.

This caused a useless manifest regeneration every ten seconds.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Since k0s uses a PDB for CoreDNS, the simple double equals equality
check wasn't appropriate to check if the CoreDNS configuration has
changed. The struct now contains a pointer which is always different for
newly constructed structs.

This caused a useless manifest regeneration every ten seconds.

Fixes: c802ffd ("Add a PodDisruptionBudget for CoreDNS")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/controlplane labels Jan 5, 2024
@twz123 twz123 added this to the 1.29 milestone Jan 5, 2024
@twz123 twz123 requested a review from a team as a code owner January 5, 2024 11:28
@twz123 twz123 requested review from kke and jnummelin January 5, 2024 11:28
@twz123 twz123 merged commit 20a3219 into k0sproject:main Jan 5, 2024
72 checks passed
@twz123 twz123 deleted the fix-coredns-reconcile branch January 5, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controlplane bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants