[Backport release-1.28] Fix helm race condition #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field isn't honored at all and we want to remove concurrent reconciliation anyway so entirely remove the field. Signed-off-by: Juan Luis de Sousa-Valadas Castaño <[email protected]> (cherry picked from commit 04ed903)
Helm is unable to reconcile multiple charts at the same time because /var/lib/k0s/helmhome/cache/ is shared between charts and helm cache was not designed to be safe to be used concurrently. Signed-off-by: Juan Luis de Sousa-Valadas Castaño <[email protected]> (cherry picked from commit e49166c)
Up to now there was a context passed but it was never cancelled. Signed-off-by: Juan Luis de Sousa-Valadas Castaño <[email protected]> (cherry picked from commit 62f0a7e)
twz123
approved these changes
Oct 26, 2023
twz123
added
bug
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.27
git worktree add -d .worktree/backport-3649-to-release-1.27 origin/release-1.27
cd .worktree/backport-3649-to-release-1.27
git checkout -b backport-3649-to-release-1.27
ancref=$(git merge-base 127c6aa587317e00dfcb24364dc5a48679dbbe12 15c1c93b3cab64a563af678618b8ddc6a6881395)
git cherry-pick -x $ancref..15c1c93b3cab64a563af678618b8ddc6a6881395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.28, triggered by a label in #3633.See #3282 #3433.