Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace footloose in tests and examples with k0sproject/bootloose #3639

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

kke
Copy link
Contributor

@kke kke commented Oct 25, 2023

Description

Since weaveworks/footloose was no longer maintained and went read-only, it was forked to kosproject/bootloose. This PR replaces all usages of footloose with the maintained bootloose fork.

Closes #3448

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke added documentation Improvements or additions to documentation area/ci chore dependencies Pull requests that update a dependency file labels Oct 25, 2023
@kke kke changed the title Replace footloose in tests and examples with the k0sproject/bootloose fork Replace footloose in tests and examples with k0sproject/bootloose Oct 25, 2023
@kke kke force-pushed the bootloose branch 3 times, most recently from e57611f to ea726c5 Compare October 25, 2023 08:16
@kke
Copy link
Contributor Author

kke commented Oct 25, 2023

It seems there is a problem with dependencies, possibly because bootloose is go 1.21.

Edit: probably because of helm

@kke kke marked this pull request as ready for review October 27, 2023 08:05
@kke kke requested a review from a team as a code owner October 27, 2023 08:05
@kke kke requested review from ncopa and juanluisvaladas October 27, 2023 08:05
@kke kke merged commit 6dffcb7 into main Oct 27, 2023
72 checks passed
@kke kke deleted the bootloose branch October 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci chore dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants