Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k0sctl to v0.16.0 #3634

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Bump k0sctl to v0.16.0 #3634

merged 1 commit into from
Oct 26, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 24, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

kke
kke previously approved these changes Oct 24, 2023
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review October 25, 2023 10:52
@twz123 twz123 requested a review from a team as a code owner October 25, 2023 10:52
@twz123 twz123 requested review from kke and makhov October 25, 2023 10:52
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite many places that need to be changed 🤔

@twz123
Copy link
Member Author

twz123 commented Oct 26, 2023

There are quite many places that need to be changed 🤔

There could be fewer places.

  1. I wonder why tool's go.mod wasn't bumped by dependabot. Maybe we were too impatient?
  2. Maybe check-network could eventually become a workflow call to ostests-e2e.
  3. Not sure about k0sctl_test.go. Maybe we could just drop that test?
  4. The changes to the Alpine files were just the removal of workarounds for v0.15.5. Changing those files won't be required in the future, hopefully.

@twz123 twz123 merged commit 9c1a0c7 into k0sproject:main Oct 26, 2023
@twz123 twz123 deleted the k0sctl-0.16.0 branch October 26, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants