Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.27] Add label selector also when watching #3624

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

k0s-bot
Copy link

@k0s-bot k0s-bot commented Oct 23, 2023

Automated backport to release-1.27, triggered by a label in #3618.
See .

The watcher was not respecting its label selector when watching, only
when listing.

Fixes: a5b617d ("Improve CoreDNS affinity check in basic inttest")
Signed-off-by: Tom Wieczorek <[email protected]>
(cherry picked from commit 75e4230)
(cherry picked from commit ac51abd)
Apparently the link format has changed a little bit and needs to be
fully percent encoded.

Signed-off-by: Tom Wieczorek <[email protected]>
(cherry picked from commit 0c54d39)
(cherry picked from commit 237049d)
@k0s-bot k0s-bot requested a review from a team as a code owner October 23, 2023 11:05
@k0s-bot k0s-bot requested review from kke and makhov October 23, 2023 11:05
@twz123 twz123 added bug Something isn't working backport/release-1.25 PR that needs to be backported/cherrypicked to release-1.25 branch labels Oct 23, 2023
@twz123 twz123 changed the title [Backport release-1.27] [Backport release-1.28] Add label selector also when watching [Backport release-1.27] Add label selector also when watching Oct 23, 2023
@twz123 twz123 added backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch and removed backport/release-1.25 PR that needs to be backported/cherrypicked to release-1.25 branch labels Oct 23, 2023
@twz123 twz123 enabled auto-merge October 24, 2023 14:37
@twz123 twz123 merged commit 395bfdf into release-1.27 Oct 27, 2023
71 checks passed
@twz123 twz123 deleted the backport-3618-to-release-1.27 branch October 27, 2023 13:02
@k0s-bot
Copy link
Author

k0s-bot commented Oct 27, 2023

Successfully created backport PR for release-1.26:

@twz123 twz123 removed the backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants