Start konnectivity BEFORE api-server #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnummelin
force-pushed
the
fix/konnectivity-startup-order
branch
3 times, most recently
from
82024bd to
ae59912
Compare
kke
reviewed
Oct 25, 2023
kke
reviewed
Oct 25, 2023
kke
reviewed
Oct 25, 2023
kke
reviewed
Oct 25, 2023
kke
reviewed
Oct 25, 2023
jnummelin
force-pushed
the
fix/konnectivity-startup-order
branch
3 times, most recently
from
f6b8d4c to
7366fec
Compare
In kube 1.28, api-server is more stringent in checking the konnectivity socket reachability. So upgrading from 1.28 make the startup quite slow. Eventually api-server does get ready and thus allows k0s to start konnectivity. To mitigate this, this PR changes the order to start konnectivity first. This requires to break down the components a bit, into three different components: * `Konnectivity`: konnectivity-server logic * `KonnectivityAgent`: Only responsible for managing the konnectivity-agent deployment into workers * `K0sControllersLeaseCounter`: Enhanced now to support pub-sub like functionality to subscribe to controll count events. ` Signed-off-by: Jussi Nummelin <[email protected]>
jnummelin
force-pushed
the
fix/konnectivity-startup-order
branch
from
7366fec to
f1ddeed
Compare
kke
approved these changes
Oct 27, 2023
jnummelin
added
the
backport/release-1.28
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In kube 1.28, api-server is more stringent in checking the konnectivity socket reachability. So upgrading from 1.28 make the startup quite slow. Eventually api-server does get ready and thus allows k0s to start konnectivity.
To mitigate this, this PR changes the order to start konnectivity first.
This requires to break down the components a bit, into three different components:
Konnectivity: konnectivity-server logicKonnectivityAgent: Only responsible for managing the konnectivity-agent deployment into workersK0sControllersLeaseCounter: Enhanced now to support pub-sub like functionality to subscribe to controll count events. `Fixes #3586
Type of change
How Has This Been Tested?
Checklist: