Remove custom Docker networks from integration tests #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using custom networks makes CoreDNS's loop plugin detect a loop and fail. Fix this by simply ripping out all custom network functionality from the inttests. An alternative would have been to apply the workarounds in k0s's Docker entrypoint also inside the inttests, but, since the custom networks apparently didn't serve any special purpose, deleting code is better than adding code. Signed-off-by: Tom Wieczorek <[email protected]>
16 tasks
juanluisvaladas
added a commit
to juanluisvaladas/k0s
that referenced
this pull request
Sep 2, 2024
Custom docker networks were removed in k0sproject#3602 because the custom networks were revealing issues in our test suite. This effectively means k0smotron cannot bump the k0s dependency to a newer version. This is a partial revert of 57b5560 getting only the minimum subset that we require for k0smotron. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using custom networks makes CoreDNS's loop plugin detect a loop and fail. Fix this by simply ripping out all custom network functionality from the inttests. An alternative would have been to apply the workarounds in k0s's Docker entrypoint also inside the inttests, but, since the custom networks apparently didn't serve any special purpose, deleting code is better than adding code.
Type of change
How Has This Been Tested?
Checklist: