Fix image detection for kubelet metrics in inttests #3553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When inttests are executed with images that contain hashes, the image detection will fail. That's because kubelet won't include the tag, but only the hash in its metrics.
Moreover, properly regex-escape the match string, pull out common logic out of the retry loop and add the missing error check to the scanner.
Type of change
How Has This Been Tested?
Checklist: