Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable race checker conditionally in Makefile #3539

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 2, 2023

Description

Instead of doing it in the CI. The Makefile is already architecture-aware, hence it makes sense to implement the conditional switch there. This gives a better experience when building and testing k0s directly on those architectures.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Instead of doing it in the CI. The Makefile is already architecture-
aware, hence it makes sense to implement the conditional switch there.
This gives a better experience when building and testing k0s directly on
those architectures.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested a review from a team as a code owner October 2, 2023 09:00
@twz123 twz123 requested review from kke and juanluisvaladas October 2, 2023 09:00
@twz123 twz123 merged commit a143532 into k0sproject:main Oct 3, 2023
73 checks passed
@twz123 twz123 deleted the disable-race-checker-in-makefile branch October 3, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants