Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cid file before invoking docker build #3469

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Sep 11, 2023

Description

Docker will refuse to overwrite the file if it already exists. This breaks the build if make figures out that the containers need to be recreated.

Example error message:

container ID file found, make sure the other container isn't running or delete .container.runc

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Docker will refuse to overwrite the file if it already exists. This
breaks the build if make figures out that the containers need to be
recreated.

Example error message:

> container ID file found, make sure the other container isn't running or delete .container.runc

Fixes: fb62d41 ("Use Docker iid files consequently in builds")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the bug Something isn't working label Sep 11, 2023
@twz123 twz123 requested a review from a team as a code owner September 11, 2023 09:27
@twz123 twz123 requested review from ncopa and kke September 11, 2023 09:27
@twz123 twz123 added this to the 1.28 milestone Sep 11, 2023
@twz123 twz123 merged commit 3368d8e into k0sproject:main Sep 13, 2023
70 checks passed
@twz123 twz123 deleted the rm-cidfile branch September 13, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants