Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop tunneled networking mode support #3441

Merged

Conversation

mikhail-sakhnov
Copy link
Contributor

@mikhail-sakhnov mikhail-sakhnov commented Aug 30, 2023

Description

Drop usage of forked version of the konnectivity

Fixes #1287

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mikhail Sakhnov added 3 commits August 30, 2023 07:14
Signed-off-by: Mikhail Sakhnov <[email protected]>
Signed-off-by: Mikhail Sakhnov <[email protected]>
@mikhail-sakhnov mikhail-sakhnov force-pushed the deprecate-tunneled-mode branch 3 times, most recently from 6209b78 to e5f50db Compare August 30, 2023 08:20
Signed-off-by: Mikhail Sakhnov <[email protected]>
@mikhail-sakhnov mikhail-sakhnov force-pushed the deprecate-tunneled-mode branch from e5f50db to 3cc3df8 Compare August 30, 2023 09:09
@mikhail-sakhnov mikhail-sakhnov marked this pull request as ready for review August 30, 2023 09:31
@mikhail-sakhnov mikhail-sakhnov requested a review from a team as a code owner August 30, 2023 09:31
@@ -72,7 +72,7 @@ const (
/* Image Constants */

KonnectivityImage = "quay.io/k0sproject/apiserver-network-proxy-agent"
KonnectivityImageVersion = "0.0.33-k0s.1"
KonnectivityImageVersion = "v0.1.4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version was built from our private image builder using the upstream source repo, unlike the previous one, which was built from the forked repo

@jnummelin jnummelin added this to the 1.28 milestone Aug 30, 2023
@juanluisvaladas juanluisvaladas merged commit 5118d38 into k0sproject:main Sep 7, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants