Fix hanging start-stop-daemon in footloose Alpine #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some distributions package Docker in a way that allows for a vast number of open file descriptors, often achieved through systemd's `LimitNOFILE=infinity` configuration. This situation leads to start- stop-daemon appearing to hang, consequently blocking the OpenRC init sequence. However, the issue is not an actual hang; rather, it attempts to close all open file descriptors, resulting in a loop with approximately one billion iterations of the close() syscall. This behavior effectively renders the footloose machine unable to boot. Mitigate this by setting the open file descriptor limit to 1 Mi in OpenRC's rc.conf. Signed-off-by: Tom Wieczorek <[email protected]> Link: moby/moby@8db6109 Link: https://github.com/OpenRC/openrc/blob/eb8831a1416ab2ee8123b3add78421c2aa316b39/src/start-stop-daemon/start-stop-daemon.c#L1104-L1105
twz123
added
chore
area/smoke-tests
backport/release-1.27
ncopa
approved these changes
Aug 29, 2023
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some distributions package Docker in a way that allows for a vast number of open file descriptors, often achieved through systemd's
LimitNOFILE=infinityconfiguration. This situation leads tostart-stop-daemonappearing to hang, consequently blocking the OpenRC init sequence. However, the issue is not an actual hang; rather, it attempts to close all open file descriptors, resulting in a loop with approximately one billion iterations of theclose()syscall. This behavior effectively renders the footloose machine unable to boot.Mitigate this by setting the open file descriptor limit to 1 Mi in OpenRC's
rc.conf.See:
Type of change
How Has This Been Tested?
Checklist: