Skip to content

Commit

Permalink
Merge pull request #3513 from twz123/backport-3512-to-release-1.25
Browse files Browse the repository at this point in the history
[Backport release-1.25] Change kubelet args passed in CLI inttest
  • Loading branch information
twz123 authored Sep 21, 2023
2 parents 7182cc0 + 90e9448 commit 01f14c7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions inttest/cli/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (s *CliSuite) TestK0sCliKubectlAndResetCommand() {

s.T().Run("k0sInstall", func(t *testing.T) {
// Install with some arbitrary kubelet flags so we see those get properly passed to the kubelet
out, err := ssh.ExecWithOutput("/usr/local/bin/k0s install controller --enable-worker --disable-components konnectivity-server,metrics-server --kubelet-extra-args='--event-qps=7 --enable-load-reader=true'")
out, err := ssh.ExecWithOutput("/usr/local/bin/k0s install controller --enable-worker --disable-components konnectivity-server,metrics-server --kubelet-extra-args='--housekeeping-interval=10s --log-flush-frequency=5s'")
assert.NoError(t, err)
assert.Equal(t, "", out)
})
Expand Down Expand Up @@ -123,9 +123,9 @@ func (s *CliSuite) TestK0sCliKubectlAndResetCommand() {

// Check that the kubelet extra flags are properly set
kubeletCmdLine, err := s.GetKubeletCMDLine(s.ControllerNode(0))
s.Require().NoError(err)
s.Require().Contains(kubeletCmdLine, "--event-qps=7")
s.Require().Contains(kubeletCmdLine, "--enable-load-reader=true")
require.NoError(err)
assert.Contains(kubeletCmdLine, "--housekeeping-interval=10s")
assert.Contains(kubeletCmdLine, "--log-flush-frequency=5s")
})

s.T().Log("waiting for k0s to terminate")
Expand Down
8 changes: 4 additions & 4 deletions inttest/common/footloosesuite.go
Original file line number Diff line number Diff line change
Expand Up @@ -1057,19 +1057,19 @@ func (s *FootlooseSuite) initializeFootlooseCluster() error {
}

// Verifies that kubelet process has the address flag set
func (s *FootlooseSuite) GetKubeletCMDLine(node string) (string, error) {
func (s *FootlooseSuite) GetKubeletCMDLine(node string) ([]string, error) {
ssh, err := s.SSH(node)
if err != nil {
return "", err
return nil, err
}
defer ssh.Disconnect()

output, err := ssh.ExecWithOutput(`cat /proc/$(pidof kubelet)/cmdline`)
if err != nil {
return "", err
return nil, err
}

return output, nil
return strings.Split(output, "\x00"), nil
}

func (s *FootlooseSuite) initializeFootlooseClusterInDir(dir string) error {
Expand Down

0 comments on commit 01f14c7

Please sign in to comment.