Skip to content

Commit

Permalink
There's no such thing as pytest.skipTest
Browse files Browse the repository at this point in the history
  • Loading branch information
s0undt3ch committed May 15, 2024
1 parent 75126a7 commit f72dd14
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/pytests/functional/modules/test_pkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ def test_pkg_upgrade_has_pending_upgrades(grains, modules):
Test running a system upgrade when there are packages that need upgrading
"""
if grains["os"] == "Arch":
pytest.skipTest("Arch moved to Python 3.8 and we're not ready for it yet")
pytest.skip("Arch moved to Python 3.8 and we're not ready for it yet")

modules.pkg.upgrade()

Expand Down Expand Up @@ -443,7 +443,7 @@ def test_pkg_upgrade_has_pending_upgrades(grains, modules):
ret = modules.pkg.install(target, version=old)
if not isinstance(ret, dict):
if ret.startswith("ERROR"):
pytest.skipTest(f"Could not install older {target} to complete test.")
pytest.skip(f"Could not install older {target} to complete test.")

# Run a system upgrade, which should catch the fact that the
# targeted package needs upgrading, and upgrade it.
Expand All @@ -457,7 +457,7 @@ def test_pkg_upgrade_has_pending_upgrades(grains, modules):
else:
ret = modules.pkg.list_upgrades()
if ret == "" or ret == {}:
pytest.skipTest(
pytest.skip(
"No updates available for this machine. Skipping pkg.upgrade test."
)
else:
Expand Down

0 comments on commit f72dd14

Please sign in to comment.