Optimized event handling & performance improvements #72
+121
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSolanaceae
commented
Oct 5, 2024
0xSolanaceae
commented
- Added helper function to mod.rs and reducing number of match arms
- Optimized draw_header_block by reducing cloning, where Text::from method is now chained to patch_style to reduce intermediate variables
- Removed unnecessary string allocation
- Combined some similar assertions in test_handle_table_scroll
- Shifted handle_key_events to hashmap to store keybindings and increase performance
…iling with -D warnings by default results in a failed build
- Optimized draw_header_block by reducing cloning, where Text::from method is now chained to patch_style to reduce intermediate variables - Removed unnecessary string allocation - Combined some similar assertions in test_handle_table_scroll - Shifted handle_key_events to hashmap to store keybindings and increase performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.