Gutenberg block #79
Open
Gutenberg block #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.6.0
Tested up to 4.7.2
Merge for release 1.6.1
Mostly working, but for some reason attributes get lost when the post is saved, despite the claim at https://developer.wordpress.org/block-editor/developers/block-api/block-attributes/ that "If no attribute source is specified, the attribute will be saved to (and read from) the block’s comment delimiter." (Also, seeing CORS policy failure on atype-video-jwplayer for localtest.me, so something's up with the last deployment of that...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a JWPlayer gutenberg bock (an embed block) where the user can search for a video and add the jwplayer shortcode to the page.
This is important because the old system of adding the shortcode at the cursor doesn't work in the gutenberg block environment. (It doesn't work because when the jw metabox is active, the cursor gets removed in the block editor.)