Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you build an OTT app for another platform than web, we cannot rely on the value of
window.location.origin
.In a lot of hybrid web-apps, this variable will contain a URL to a local webserver. Eg.
capacitor://localhost
for Capacitor based platforms.This caused two bugs:
While we fixed this issue, we took it a step further to completely remove
window.location.origin
references throughout the project.When
APP_PUBLIC_URL
is not defined within your (web).env
-file, we still fallback on the the same value, making this a non-breaking change.