Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework / UI improvements #634

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Rework / UI improvements #634

merged 9 commits into from
Nov 6, 2024

Conversation

royschut
Copy link
Collaborator

@royschut royschut commented Nov 6, 2024

Rework / UI improvements

This PR fixes some issues on the FeaturedShelf and general UI updates, found during our manual testing process:

  • Fix: Too little vertical spacing on the playlist page
  • Fix: Disabled featured pagination buttons have a pointer cursor
  • Fix: Featured shelf not respecting safe area (mobile app)
  • Fix: Searchbar not vertically centered (mobile)
  • Fix: Broken featured shelf animation
  • Fix: More info button not available (mobile). I've also made the More Info button into a CTA in every case that there is no Start Watching button
  • Fix: Unwanted fixed hero background. We intend to make it fixed, with a fade out on scroll, like we do with the featured shelf, but this is scheduled for another moment.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Nov 6, 2024

Visit the preview URL for this PR (updated for commit 49f2b3e):

https://ottwebapp--pr634-rework-ui-improvemen-qfajmmpq.web.app

(expires Fri, 06 Dec 2024 12:49:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@royschut royschut marked this pull request as ready for review November 6, 2024 12:45
Copy link
Collaborator

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me! I also previewed them in my browser (desktop and mobile size).

Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@royschut royschut merged commit 085e245 into develop Nov 6, 2024
10 checks passed
@royschut royschut deleted the rework/ui-improvements branch November 6, 2024 20:29
This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants