feat(project): OWA-56 add DRM check for CDN analytics #469
Conversation
|
Visit the preview URL for this PR (updated for commit 3186c28): https://ottwebapp--pr469-owa-56-web-app-user-pq44p614.web.app (expires Sat, 20 Apr 2024 14:42:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
| const cdnUrlVOD = `https://cdn.jwplayer.com/manifests/${mediaId}.m3u8`; | ||
| const cdnUrlBCL = `https://content.jwplatform.com/live/broadcast/${mediaId}.m3u8`; |
There was a problem hiding this comment.
Do you think we should remove the extension check? The sources could also contain MPEG-DASH or MP4 files that won't have the analytic parameters.
There was a problem hiding this comment.
Hey Christiaan, that is a good catch. I was referring to Marco's previous notes while working on this task.
Even though it is still blocked by Media Core team I would suggest discussing this in our monthly sync.
CC: @dbudzins @AntonLantukh
| @@ -5,10 +5,12 @@ import type { PlaylistItem, Source } from '../../types/playlist'; | |||
|
|
|||
| export const attachAnalyticsParams = (item: PlaylistItem) => { | |||
There was a problem hiding this comment.
Not related to your change, but this function mutates the given item, should we create a new object instead?
export const attachAnalyticsParams = (item: PlaylistItem) => {
const updatedSources = item.sources.map(source => {
// logic
return { ...source, file: url.toString() };
});
return { ...item, sources: updatedSources };
};
Description
OWA-52
Steps completed:
According to our definition of done, I have completed the following steps: