Templatizedir #64
Closed
Templatizedir #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#57 does something similar and was merged. |
|
I do think there are a couple of things that I had done that are still useful. I merged the change from @breml and made a minor enhancement to make it able to walk a whole directory tree, and added in the unit tests that I had created. Can we reopen/merge or would you be open to me creating a new one? |
|
@jmahowald Sure. Can you rebase and update the description with some details about the enhancement you've made? |
|
I made a mess of the rebase so just created a new clean pull |
|
Can we do #70 instead? Same commits, but I just manually "rebased" them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have to add in new -template commands for each template, when there are potentially multiple files, decided that it would be nice to be able to use an entire directory tree and copy that over.
I should probably add into the README but wanted to check to see if you overall think the change makes sense.