Added a test for mailto: links

justinwalsh · Jan 23, 2017 · 2b1bfbf · 2b1bfbf
1 parent 77541b6
commit 2b1bfbf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/libs/ContentTypes/Markdown/LinkRenderer.php b/libs/ContentTypes/Markdown/LinkRenderer.php
@@ -65,7 +65,7 @@ protected function isValidUrl($url)
 
     protected function isExternalUrl($url)
     {
-        return preg_match('|^(?:[a-z]+:)?//|', $url) || substr($url, 0, 7) == "mailto:";
+        return preg_match('#^(?:[a-z]+:)?//|^mailto:#', $url);
     }
 
     /**

diff --git a/tests/ContentTypes/Markdown/LinkRendererTest.php b/tests/ContentTypes/Markdown/LinkRendererTest.php
@@ -51,6 +51,9 @@ public function providerRenderLink()
             // /Content/Page
             ['<a href="../Widgets/Button.html">Link</a>', '[Link](../Widgets/Button.md)', 'Content/Page.html'],
             ['<a href="../Widgets/Button.html">Link</a>', '[Link](!Widgets/Button)', 'Content/Page.html'],
+
+            // Mailto links
+            ['<a href="mailto:[email protected]" class="external">[email protected]</a>', '[[email protected]](mailto:[email protected])', 'Content/Page.html'],
         ];
     }