Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for #238 regression / #245 issue #247

Merged
merged 2 commits into from
May 13, 2024

Conversation

melomac
Copy link
Contributor

@melomac melomac commented May 6, 2024

Use --version command-line option to read current fish-shell version rather than parsing assumed, configuration altered, fish command output.

@melomac melomac force-pushed the fish_version_regex branch 2 times, most recently from 56212b5 to 2869437 Compare May 6, 2024 17:41
@melomac
Copy link
Contributor Author

melomac commented May 6, 2024

Amended commit to revert Python 3.6's encoding="utf8" to better backward compatible .decode("utf-8")

@melomac melomac force-pushed the fish_version_regex branch from 2869437 to 1d91980 Compare May 6, 2024 17:48
@melomac
Copy link
Contributor Author

melomac commented May 6, 2024

Used verified email address 😬

@justinmayer
Copy link
Owner

Many thanks for proposing a fix, @melomac. Sorry to ask what may seem like a silly question, but is it safe to assume that you have tested this, and it works? 😊

@melomac
Copy link
Contributor Author

melomac commented May 6, 2024

Hi @justinmayer

I checked the regex on current fish-shell stable and fish-shell git (for the - right strip thing).

I was able to uninstall / install with python3.12 and python3.9 with no problem.

And I tried to figure out when the --version option landed in fish-shell project with no certainty, but I am confident this was well before virtualfish minimum required version.

Many thanks for virtualfish 🙏

Copy link
Owner

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the kind words, @melomac, as well as for the enhancement. Much appreciated! 🌟

@justinmayer justinmayer merged commit 78bf552 into justinmayer:main May 13, 2024
2 checks passed
@melomac melomac deleted the fish_version_regex branch May 13, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants