Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-000 mention pie-webc more and remove next13 examples #2089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Nov 20, 2024

Describe your changes (can list changeset entries if preferable)

  • Removes the nextjs 13 mentions from each component code page
  • Clearly mention the pie-webc package on the docs site engineers pages

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 4672a74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamieomaguire jamieomaguire marked this pull request as ready for review November 20, 2024 17:21
@jamieomaguire jamieomaguire requested review from a team as code owners November 20, 2024 17:21
@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Nov 20, 2024


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against 4672a74

@@ -12,15 +12,12 @@ permalink: engineers/web-components/

Currently, this technology is supported by all browsers, making it possible to have one central library that will work with most frontend frameworks.

The long-term aim will be to migrate JET teams over to this Web Component System, so we have one single source of truth for our global PIE components.
The long-term aim will be to migrate JET teams over to this Web Component system, so we have one single source of truth for our global PIE components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The long-term aim will be to migrate JET teams over to this Web Component system, so we have one single source of truth for our global PIE components.
The long-term aim is to migrate JET teams over to this Web Component system, so we have one single source of truth for our global PIE components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants